fix(tides): fix stale locations in frontend and implement digraph fallback & direct BSH matching on server

client/src/components/LiveLogView.tsx

@@ -68,7 +68,8 @@ import {
 import {
   fetchTidesForEntry,
   fetchTidesForStationChoice,
-  type TideFetchNeedsStationPick
+  type TideFetchNeedsStationPick,
+  type TideFetchResult
 } from '../utils/tideFetch.js'
 import {
   geolocationErrorI18nKey,
@@ -851,17 +852,10 @@ export default function LiveLogView({
     setError(null)
     void (async () => {
       try {
-        const loaded = await loadEntry(logbookId, entryId)
-        const eventsForLocation = loaded
-          ? sortLogEventsByTime((loaded.data.events as LogEventPayload[]) || [])
-          : events
-        const entryDateForLocation = loaded ? String(loaded.data.date || date) : date
-        const departureForLocation = loaded ? String(loaded.data.departure || departure) : departure
-
         const location = resolveTideFetchLocation({
-          events: eventsForLocation,
-          entryDate: entryDateForLocation,
-          departure: departureForLocation
+          events,
+          entryDate: date,
+          departure
         })
         if ('error' in location) {
           void showAlert(
@@ -875,19 +869,20 @@ export default function LiveLogView({
 
         const outcome = await fetchTidesForEntry({
           fetchLocation: location,
-          entryDate: entryDateForLocation,
+          entryDate: date,
           analyticsSource: 'live_log'
         })
 
-        if (outcome.kind === 'pick_station') {
-          setTideStationPicker(outcome)
+        if ('kind' in outcome && outcome.kind === 'pick_station') {
+          setTideStationPicker(outcome as TideFetchNeedsStationPick)
           return
         }
 
+        const result = outcome as TideFetchResult
         setTidePreview({
-          highWater: outcome.highWater,
-          lowWater: outcome.lowWater,
-          location: outcome.location
+          highWater: result.highWater,
+          lowWater: result.lowWater,
+          location: result.location
         })
         setModal('tides')
       } catch (err) {

client/src/components/LogEntryEditor.tsx

@@ -54,7 +54,8 @@ import {
 import {
   fetchTidesForEntry,
   fetchTidesForStationChoice,
-  type TideFetchNeedsStationPick
+  type TideFetchNeedsStationPick,
+  type TideFetchResult
 } from '../utils/tideFetch.js'
 import {
   buildTravelDayContext,
@@ -62,7 +63,7 @@ import {
   generateTravelDaySummary,
   TravelDaySummaryApiError
 } from '../services/aiSummary.js'
-import { loadEntry, tryDecryptEntryPayload } from '../services/quickEventLog.js'
+import { tryDecryptEntryPayload } from '../services/quickEventLog.js'
 import { getAiAuthorized } from '../services/userPreferences.js'
 import {
   getDecryptedTrack,
@@ -1351,17 +1352,10 @@ export default function LogEntryEditor({
 
     setTidesLoading(true)
     try {
-      const loaded = await loadEntry(logbookId, entryId)
-      const eventsForLocation = loaded
-        ? sortLogEventsByTime((loaded.data.events as LogEventPayload[]) || [])
-        : events
-      const entryDateForLocation = loaded ? String(loaded.data.date || date) : date
-      const departureForLocation = loaded ? String(loaded.data.departure || departure) : departure
-
       const location = resolveTideFetchLocation({
-        events: eventsForLocation,
-        entryDate: entryDateForLocation,
-        departure: departureForLocation
+        events,
+        entryDate: date,
+        departure
       })
       if ('error' in location) {
         if (location.error === 'stale') {
@@ -1374,16 +1368,16 @@ export default function LogEntryEditor({
 
       const outcome = await fetchTidesForEntry({
         fetchLocation: location,
-        entryDate: entryDateForLocation,
+        entryDate: date,
         analyticsSource: 'entry_editor'
       })
 
-      if (outcome.kind === 'pick_station') {
-        setTideStationPicker(outcome)
+      if ('kind' in outcome && outcome.kind === 'pick_station') {
+        setTideStationPicker(outcome as TideFetchNeedsStationPick)
         return
       }
 
-      applyTideFetchResult(outcome)
+      applyTideFetchResult(outcome as TideFetchResult)
     } catch (err) {
       if (err instanceof TidesApiError) {
         if (err.code === 'OFFLINE') {